Add a header to the vmmap table #1311
Conversation
A simple header has been added to the output of vmmap which helps new users identify the columns.
Adjust the length of expected vmmaps
There was a problem hiding this comment.
Overall this lgtm. For the lint issue, you can run ./lint.sh -f locally (more details here: https://github.com/pwndbg/pwndbg/blob/dev/DEVELOPING.md). For the tests, it seems like there are more tests that use the vmmap output that you'll need to update with the header. You can run ./tests.sh locally to reproduce this.
| """ | ||
| width = 2 + 2 * pwndbg.gdblib.arch.ptrsize | ||
| fmt_string = "%#{}s %#{}s %#4s %#8s %#6s %s".format(width, width) | ||
| print(fmt_string % ("Start", "End", "Perm", "Size", "Offset", "File")) |
There was a problem hiding this comment.
nitpick: we can probably do all this in the previous format() call, right? If so, we should probably just do that.
There was a problem hiding this comment.
we can probably use f-string literal for all this
There was a problem hiding this comment.
I know but I don't think it is that big deal; it was also copied from another part of the code ;p
we can easily fix it too :P
Codecov Report
@@ Coverage Diff @@
## dev #1311 +/- ##
==========================================
- Coverage 54.67% 54.64% -0.04%
==========================================
Files 156 156
Lines 19263 19397 +134
Branches 1785 1804 +19
==========================================
+ Hits 10533 10599 +66
- Misses 8284 8361 +77
+ Partials 446 437 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
A simple header has been added to the output of vmmap which helps new users identify the columns.