-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in parallel with GNU parallel #1332
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1332 +/- ##
==========================================
- Coverage 54.92% 54.87% -0.06%
==========================================
Files 153 153
Lines 19363 19387 +24
Branches 1811 1815 +4
==========================================
+ Hits 10636 10639 +3
- Misses 8277 8298 +21
Partials 450 450
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
With the latest commit the test pass/fail count is fixed. But I still need to get the names of the failed tests, which is feature I just added that now doesn't work with this approach 😅. Also, for some reason ~5 tests fail when run under parallel, I'm not sure why yet. |
The latest commit fixes some issues where we used hardcoded /tmp paths in our tests, which obviously break with multiple tests using the same file. This was fixed by using The last test failures look like this:
|
Ok, all bugs are fixed now. This is ready for review and can be merged if it looks good. It would also be good to only display the output of failing jobs, but I will make that in a followup PR, as that's new functionality. |
Note: this isn't ready to be merged. The tests run in parallel, but I still need to figure out how to update the test failed/success count.
Also need to add parallel to the dev dependencies.
Fixes #1330