Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1364: update unicorn to 2.0.1 #1366

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

profesorek96
Copy link
Contributor

Removed version lib unicorn in file requirements.txt. This change allow run pwndbg in Parallels MacBook with M1

@gsingh93 gsingh93 self-requested a review November 10, 2022 21:11
Copy link
Member

@gsingh93 gsingh93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably break Ubuntu 18.04, as it uses an older version of unicorn for a reason. You'll need to revert back to the original, and then just change 2.0.0 to 2.0.1.

@disconnect3d
Copy link
Member

disconnect3d commented Nov 10, 2022

@gsingh93 u sure? the CI for 18.04 passed; aren't we testing for this behavior?

@disconnect3d
Copy link
Member

@gsingh93 Ah. You commented before another commit send to this branch, nvm. It works now with hardcoded ==2.0.1.

@gsingh93
Copy link
Member

I think we still need to keep the Python check for 18.04. CI will pass until the docker PR is merged, so we can't trust it.

Removed version lib unicorn in file requirements.txt. This change allow run pwndbg in Parallels MacBook with M1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants