Use .data instead of .got.plt in the heap heuristic
#1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When libc has no symbols, to search the `main_arena` and `mp_` in the memory, we will need to find which page is possible to have those symbols first. Before this commit, we used `.got.plt` to determine it, but it might fail in some cases. Using the address of `.data` should be a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When libc has no symbols, to search the
main_arenaandmp_in the memory, we will need to find which page is possible to have those symbols first.Before this PR, we used
.got.pltto determine it, but it might find wrong page in some cases. Using the address of.datashould be a better solution.Some failing test about heuristic found in the archlinux tests in #1378 should pass after this PR.