Fix find_fake_fast command test #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a more reliable method for mapping one of the fake chunks such that its heap_info struct is guaranteed to be unmapped.
Codecov Report
@@ Coverage Diff @@
## dev #1397 +/- ##
=======================================
Coverage 58.14% 58.14%
=======================================
Files 155 155
Lines 19582 19582
Branches 1840 1840
=======================================
Hits 11385 11385
Misses 7636 7636
Partials 561 561 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Failing tests appear unrelated to this PR: Docker build (ubuntu 18.04) - Failing tests: tests/test_cymbol.py::test_cymbol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a more reliable method for mapping one of the fake chunks used in this suite of tests.
Part of the test setup requires the
fake_chunksize field to be aligned in virtual memory such that itsheap_infostruct resides in unmapped memory. Previously this was left up to ASLR and the test would intermittently fail when the fake chunk'sheap_infostruct was actually mapped. The updated test attempts tommap()2 pages aligned toHEAP_MAX_SIZE, when successful it placesfake_chunkin the 2nd page thenmunmap()s the 1st page, ensuring the fake chunk'sheap_infostruct is unmapped.