Fix plt and gotplt commands #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #1576 +/- ##
==========================================
+ Coverage 58.32% 58.83% +0.50%
==========================================
Files 169 171 +2
Lines 20343 20749 +406
Branches 1832 1944 +112
==========================================
+ Hits 11865 12207 +342
- Misses 7901 7960 +59
- Partials 577 582 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alufers
pushed a commit
to alufers/pwndbg
that referenced
this pull request
Apr 14, 2023
* Fix plt and gotplt commands * Add plt gotplt commands tests * Fix got and plt commands and test them * Revert accidental change * Extend system path * Hopefully fix PATH problems once and for all? * fix import * remove redundant part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
plt,gotpltandgotcommands on both PIE and non-PIE binariesgotcommand on PIE binaries which had the binary executable memory page not being the first binary vmmap pagepwndbg.gdblib.symbol.get(...)for low addresses when binary hasn't been started yet and the symbols are not rebased yet by GDBand adds some tests for plt/gotplt/got.
I also compile a reference pie & non-pie binary via zig so that we get a more reproducible build of the binary across different distros, at least hopefully :P