Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print all chunks in vis_heap_chunks #1604

Merged
merged 5 commits into from Mar 7, 2023
Merged

Add print all chunks in vis_heap_chunks #1604

merged 5 commits into from Mar 7, 2023

Conversation

neryaz
Copy link
Contributor

@neryaz neryaz commented Mar 5, 2023

vis_heap_chunks is Visualize chunks on a heap.
Now this function support to print all chunks in arena.

According to cdd71a1 --display_all/-d moved to --no_truncate/-n
@codecov-commenter
Copy link

Codecov Report

Merging #1604 (f594f58) into dev (9d22acc) will decrease coverage by 0.05%.
The diff coverage is 38.88%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #1604      +/-   ##
==========================================
- Coverage   58.78%   58.74%   -0.05%     
==========================================
  Files         172      172              
  Lines       20500    20545      +45     
  Branches     1784     1797      +13     
==========================================
+ Hits        12051    12069      +18     
- Misses       7878     7904      +26     
- Partials      571      572       +1     
Impacted Files Coverage Δ
pwndbg/commands/ai.py 25.88% <21.42%> (-3.29%) ⬇️
pwndbg/commands/heap.py 74.86% <100.00%> (+0.20%) ⬆️
pwndbg/heap/ptmalloc.py 71.26% <100.00%> (-0.14%) ⬇️
pwndbg/gdblib/symbol.py 54.54% <0.00%> (-3.09%) ⬇️
pwndbg/gdblib/events.py 80.41% <0.00%> (+1.39%) ⬆️
pwndbg/glibc.py 80.61% <0.00%> (+3.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@disconnect3d
Copy link
Member

@CptGibbon offered to review this next week

Copy link
Collaborator

@CptGibbon CptGibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new argument names are descriptive.
The mutually exclusive arguments are a nice touch.
Not much to test but the option does what it claims so I'm happy, simple yet effective 👌

@disconnect3d disconnect3d merged commit bdbd4ed into pwndbg:dev Mar 7, 2023
alufers pushed a commit to alufers/pwndbg that referenced this pull request Apr 14, 2023
* Changing the arguments to vis_heap_chunks to be clearer

1. --native to --beyond_top
2. --display_all to --no_truncate

* Add print all chunks to vis_heap_chunks

* Preventing the use of the all_chunks argument together with the count argument in vis_heap_chunks

* Use linting for heap.py

* Fix test_vis_heap_chunks.py
According to cdd71a1 --display_all/-d moved to --no_truncate/-n

---------

Co-authored-by: Nerya Zadkani <nerya@tokagroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants