New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add print all chunks in vis_heap_chunks #1604
Conversation
1. --native to --beyond_top 2. --display_all to --no_truncate
… argument in vis_heap_chunks
According to cdd71a1 --display_all/-d moved to --no_truncate/-n
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #1604 +/- ##
==========================================
- Coverage 58.78% 58.74% -0.05%
==========================================
Files 172 172
Lines 20500 20545 +45
Branches 1784 1797 +13
==========================================
+ Hits 12051 12069 +18
- Misses 7878 7904 +26
- Partials 571 572 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@CptGibbon offered to review this next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new argument names are descriptive.
The mutually exclusive arguments are a nice touch.
Not much to test but the option does what it claims so I'm happy, simple yet effective 👌
* Changing the arguments to vis_heap_chunks to be clearer 1. --native to --beyond_top 2. --display_all to --no_truncate * Add print all chunks to vis_heap_chunks * Preventing the use of the all_chunks argument together with the count argument in vis_heap_chunks * Use linting for heap.py * Fix test_vis_heap_chunks.py According to cdd71a1 --display_all/-d moved to --no_truncate/-n --------- Co-authored-by: Nerya Zadkani <nerya@tokagroup.com>
vis_heap_chunks
is Visualize chunks on a heap.Now this function support to print all chunks in arena.