Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heap_config: validate glibc version when 'glibc' param is set #1826

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

disconnect3d
Copy link
Member

The only disadvantage of this is that we now display the glibc version as a tuple like this:

pwndbg> set glibc 2.32
Set GLIBC version for heap heuristics resolution (e.g. 2.31) to (2, 32).
pwndbg> heap_config glibc
Name        Value (Default)    Documentation
--------------------------------------------
glibc       (2, 32) ('')       GLIBC version for heap heuristics resolution (e.g. 2.31)

But I think this is fine.

Fixes #1801

The only disadvantage of this is that we now display the glibc version
as a tuple like this:

```
pwndbg> set glibc 2.32
Set GLIBC version for heap heuristics resolution (e.g. 2.31) to (2, 32).
pwndbg> heap_config glibc
Name        Value (Default)    Documentation
--------------------------------------------
glibc       (2, 32) ('')       GLIBC version for heap heuristics resolution (e.g. 2.31)
```

But I think this is fine.
@disconnect3d
Copy link
Member Author

image

@disconnect3d disconnect3d merged commit 6271157 into dev Jul 21, 2023
8 checks passed
@disconnect3d disconnect3d deleted the validate-glibc-on-set branch July 21, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

heap_config should give an example format for GLIBC version
1 participant