Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing fixes #1970

Merged
merged 35 commits into from
Jan 2, 2024
Merged

Typing fixes #1970

merged 35 commits into from
Jan 2, 2024

Conversation

disconnect3d
Copy link
Member

This is the #1968 PR with further enhancements

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (91d1a04) 60.49% compared to head (8dcd5cd) 58.62%.
Report is 3 commits behind head on dev.

Files Patch % Lines
pwndbg/lib/funcparser.py 66.66% 11 Missing ⚠️
pwndbg/gdblib/vmmap.py 72.97% 9 Missing and 1 partial ⚠️
pwndbg/commands/__init__.py 86.88% 8 Missing ⚠️
pwndbg/commands/telescope.py 58.82% 5 Missing and 2 partials ⚠️
pwndbg/gdblib/elf.py 84.21% 3 Missing ⚠️
pwndbg/auxv.py 81.81% 2 Missing ⚠️
pwndbg/commands/cymbol.py 77.77% 2 Missing ⚠️
pwndbg/lib/which.py 0.00% 2 Missing ⚠️
gdbinit.py 0.00% 1 Missing ⚠️
pwndbg/commands/ai.py 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1970      +/-   ##
==========================================
- Coverage   60.49%   58.62%   -1.87%     
==========================================
  Files         183      183              
  Lines       22496    22630     +134     
  Branches     2127     2127              
==========================================
- Hits        13608    13267     -341     
- Misses       8165     8677     +512     
+ Partials      723      686      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disconnect3d disconnect3d merged commit c4b71af into dev Jan 2, 2024
13 checks passed
@disconnect3d disconnect3d deleted the typing-fixes branch January 2, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants