Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit ChunkField from int, Enum #2210

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

CptGibbon
Copy link
Contributor

Fixes #2209

@CptGibbon
Copy link
Contributor Author

The lint failure has nothing to do with this PR 😅

@CptGibbon
Copy link
Contributor Author

I used the int mixin form instead of IntEnum because I couldn't find which version of Python introduced IntEnum.
If there's a good reason to use IntEnum I can of course change it.

@gsingh93
Copy link
Member

gsingh93 commented Jun 7, 2024

I just changed the version at the top of the python docs to check if it still existed in an older version, and it does: https://docs.python.org/3.6/library/enum.html#enum.IntEnum

But I'm fine with the mixin too.

BTW, GitHub actions should have an Ubuntu 24.04 runner image now we can use that would have caught this issue. And/or we should add it to docker.

@gsingh93
Copy link
Member

gsingh93 commented Jun 7, 2024

Did you test with Python 3.11/3.12, or should we update the CI first and see if this PR passes?

@xtexChooser
Copy link
Contributor

@gsingh93 I am using python3.11 and it is working for me.

@disconnect3d
Copy link
Member

@xtexChooser just to be sure: you mean this PR is working for you? or code before this PR?

@xtexChooser
Copy link
Contributor

@disconnect3d this PR does fixed the error mentioned above for me, although I am still experiencing #2171 and #1754.

@disconnect3d
Copy link
Member

@disconnect3d disconnect3d merged commit 8625b30 into pwndbg:dev Jun 7, 2024
12 of 13 checks passed
@disconnect3d
Copy link
Member

@xtexChooser Which error are u getting with #2171?

Is that about ptrace scope? If so, that's purely privileges issue on your side. If that is something else, that's a Pwndbg bug.

Regarding #1754 I don't have time currently to look at it, I'd appreciate any help in debugging/investigating or fixing it. It seems like a GDB/GDBServer bug, but maybe it isn't, I am not sure. If its GDB-GDBServer bug, we should report it to upstream GDB project bugzilla.

@xtexChooser
Copy link
Contributor

xtexChooser commented Jun 7, 2024

@disconnect3d For #2171, the AttributeError, which is mentioned to be a upstream bug. For #1754, it happens when connecting to a x86_64 QEMU VM (the QEMU option -s) after gdb-ing a i386 ELF, only when the architecture of the qemu server differs from the ELF's. (seems to be a GDB bug, it is still here even when pwndbg is not loaded
Thanks for merging this PR.

@CptGibbon CptGibbon deleted the fix-int-enum branch June 7, 2024 18:32
xtexChooser added a commit to xtexChooser/central that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Celan Install, error at startup on import pwndbg
4 participants