Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the installation script for each distros. #540

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

claudiajkang
Copy link
Contributor

This commit adds the installation script for each distros in setup.sh.

Also, the content of the script was changed to install all the required packages for pwndbg in each distros.

Fixed : #296

Signed-off-by: Claudia J. Kang claudiajkang@gmail.com

This commit adds the installation script for each distros in setup.sh.

Also, the content of the script was changed to install all the required packages for pwndbg in each distros.

Fixed : pwndbg#296

Signed-off-by: Claudia J. Kang <claudiajkang@gmail.com>
@disconnect3d
Copy link
Member

The travis check can be ignored: it fails on isort from another PR (weird we missed it).

@disconnect3d
Copy link
Member

disconnect3d commented Oct 11, 2018

So I tried to run this on a docker container with fedora, launched as: docker run --rm -it --cap-add=SYS_PTRACE fedora bash, and executed those commands:

  • dnf install git vim
  • cloned your repo, checkouted this branch
  • modified setup.sh and removed all sudo occurences as there is no sudo inside docker
  • ./setup.sh

It failed on:

  Running setup.py install for capstone ... error
    Complete output from command /usr/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-_8jc5lbe/bindings/python/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-bow4wh2x/install-record.txt --single-version-externally-managed --compile --home=/tmp/pip-target-war3cplj:
    /usr/lib/python3.6/site-packages/setuptools/dist.py:398: UserWarning: Normalizing '4.0.0.rc1' to '4.0.0rc1'
      normalized_version,
    running install
    running build
    Building C extensions
    ./make.sh: line 113: make: command not found
    error: [Errno 2] No such file or directory: 'libcapstone.so.4'
    
    ----------------------------------------
Command "/usr/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-_8jc5lbe/bindings/python/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-bow4wh2x/install-record.txt --single-version-externally-managed --compile --home=/tmp/pip-target-war3cplj" failed with error code 1 in /tmp/pip-req-build-_8jc5lbe/bindings/python

as it lacked make, huh.

I modified setup.sh and added make to dnf install and it installed and works fine.

I am making a manual change to the dnf install line to include make.

;;
"fedora")
sudo dnf update || true
sudo dnf -y install gdb python-devel python3-devel python-pip python3-pip glib2-devel make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the file and added make here so it builds now.

@disconnect3d
Copy link
Member

disconnect3d commented Oct 11, 2018

@zachriggle It is good to be merged for me. We can ignore travis as it fails on isort which is not related here.

@zachriggle
Copy link
Contributor

zachriggle commented Oct 11, 2018 via email

@disconnect3d disconnect3d merged commit e61b055 into pwndbg:dev Oct 11, 2018
@disconnect3d
Copy link
Member

@claudiajkang Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants