Fix #681 #693
Merged
Fix #681 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disconnect3d
reviewed
Dec 9, 2019
| @@ -33,7 +33,7 @@ def get_file(path, recurse=1): | |||
| local_path = path | |||
|
|
|||
| if pwndbg.qemu.root() and recurse: | |||
| return get(os.path.join(pwndbg.qemu.binfmt_root, path), 0) | |||
| return os.path.join(pwndbg.qemu.binfmt_root, path) | |||
There was a problem hiding this comment.
So it turns out that instead of returning local path we could have returned bytes read from the file.
Uh...
There was a problem hiding this comment.
Btw shouldn't have the the if order reversed, i.e. first check for remote and then for pwndbg.qemu.root()?
Also, what is the situation when pwndbg.qemu.root() is used? I have qemu user on my system but I don't have the /etc/qemu-binfmt it tries to check :S.
There was a problem hiding this comment.
It's arbitrarily set by debian version of qemu as the default value of QEMU_LD_PREFIX. qemu-arm-static --help is showing it.
~/qemu-2.11+dfsg $ grep -r interp-prefix
debian/rules: --interp-prefix=/etc/qemu-binfmt/%M \
...
|
Even though I asked a question I think this fix is valid. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.