-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mappings): add config option to disable default mappings #514
Conversation
@konosubakonoakua Thanks! please document the new config option both in the README and doc/octo.txt |
also align colors and mappings code for better vision should close pwntester#507
2252652
to
9bf5958
Compare
Done~, please review again. 😄 |
Thank you! |
hey thanks @pwntester and @konosubakonoakua I just tested this and I'm getting errors when the value is set to ![]() |
Could you put your config for octo here? I can not reproduce with the config I pasted here |
This is what i have 🙂 I've set |
@ckangnz could not reproduce with your config, btw I removed the color setting, are you using the latest version of octo.nvim? |
@konosubakonoakua Yes i am using the latest version. I can see |
Strange. could you try konosubakonoakua/octo.nvim ? |
@pwntester hey yes it definitely fixed the issue 🙂 Awesome work! Thank you 🙂 |
Describe what this PR does / why we need it
add option to disable default mappings also align colors and mappings code for better vision
Does this pull request fix one issue?
Fixes #507
Describe how you did it
check mappings_disable_default flag before merging user config, if true, set default mappings to
{}
Describe how to verify it
Special notes for reviews