Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Integrate demo changes into master #13

Closed
JonasVautherin opened this issue Oct 9, 2017 · 2 comments
Closed

Integrate demo changes into master #13

JonasVautherin opened this issue Oct 9, 2017 · 2 comments
Assignees

Comments

@JonasVautherin
Copy link
Contributor

JonasVautherin commented Oct 9, 2017

Some lessons have been learned from the local_planner demo. A few values were hard-coded for the sake of the demo, and should be merged into master.

Refactor the demo branch and merge what needs to be kept into master.

NOTE: this issue is meant to address PR #10.

@mrivi
Copy link
Contributor

mrivi commented Oct 13, 2017

I don't think it's a good idea to merge the demo branch into master. In the demo branch there is different behavior (if obstacle in front of the drone go back 1m, if obstacle removed move forward 1m) from the normal local planner. In order to achieve it there are a bunch of if statements in the code.

I would propose to keep a separate demo branch to be used if we want to showcase this behavior.

@JonasVautherin
Copy link
Contributor Author

Agreed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants