Only start workflows on pushes to master #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to run workflows on pushes to other branches, these branches will have to go through a PR to get into master at which points, the workflows will be ran. (Even if they wouldn't go through a PR, push on master would mean running the workflow). Since we're treating other branches as feature branches, there's no reason to run workflows on them up until they're in a PR
ItsDrike
added
area: CI
kevinkjt2000
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're treating other branches as feature branches, there's no reason to run workflows on them up until they're in a PR. GitHub does limit the amount of concurrent workflows which we can run and having these workflows run on both pull request and push on any branch can mean that if that PR is made from a local feature branch, we're running the checks twice for no reason (once on push to local branch, and once on PR).
To avoid this, this PR changes this behavior and only runs the workflows on pull requests, or to pushes to master branch, bot not to any other branch.