Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run command for generating payload with bash #230

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

ItsDrike
Copy link
Member

@ItsDrike ItsDrike commented Feb 22, 2022

In #220, I've added a new job to the tox-lint workflow which generates an artifact which we then upload and is used from the status-embed workflow. However in that PR, I didn't notice that this generation was failing for windows each time. This is happening since the job was running a command which couldn't be executed on powershell. This PR fixes that by explicitly stating that the shell for this command should be bash, even on windows.

This isn't something critical since this workflow artifact generation job isn't required for the workflow to pass, but it should be fixed to avoid not being able to access some details about the workflow later in the status-embed job.

Blocked by:

@ItsDrike ItsDrike added area: CI Related to continuous intergration and deployment status: needs review Author is waiting for someone to review and approve type: bug Something isn't working labels Feb 22, 2022
@ItsDrike ItsDrike changed the title Run command for generating paylond with bash Run command for generating payload with bash Feb 25, 2022
@kevinkjt2000 kevinkjt2000 merged commit 29d3cd4 into py-mine:master Feb 25, 2022
@ItsDrike ItsDrike deleted the fix-artifact-upload-on-win branch March 8, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI Related to continuous intergration and deployment status: needs review Author is waiting for someone to review and approve type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants