Move zeros in the packet to follow documentation update #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
changed the title
PerchunPak
approved these changes
Jul 1, 2023
ItsDrike
approved these changes
Jul 2, 2023
kevinkjt2000
pushed a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"01" + "000000000000000000" + "ffff00fefefefefdfdfdfd12345678" + "0000000000000000"
According to https://wiki.vg/Raknet_Protocol#Unconnected_Ping, the packet is a byte, (01), followed by 8 bytes for the time. In the code, there are 9 bytes in that part! (two extra zeroes!)
After the time, it should be followed by MAGIC.
Now, wiki.vg says the following about it:
Oh! There are the first two zeroes missing! I wonder where they went? (spoiler: they are in the part for the time...)
TL;DR: I moved two zeroes