Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Make encryption module private, apply pre-commit #1010

Merged
merged 3 commits into from Jun 19, 2022

Conversation

MartinThoma
Copy link
Member

@MartinThoma MartinThoma commented Jun 19, 2022

Related to #749

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #1010 (310ce89) into main (868f977) will not change coverage.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          19       19           
  Lines        4423     4423           
  Branches      923      923           
=======================================
  Hits         3947     3947           
  Misses        323      323           
  Partials      153      153           
Impacted Files Coverage Δ
PyPDF2/_encryption.py 72.85% <85.71%> (ø)
PyPDF2/_merger.py 87.15% <100.00%> (ø)
PyPDF2/_reader.py 91.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868f977...310ce89. Read the comment docs.

@MartinThoma MartinThoma marked this pull request as ready for review June 19, 2022 06:59
@MartinThoma MartinThoma merged commit 797963a into main Jun 19, 2022
@MartinThoma MartinThoma deleted the cleanup-2022-0-19 branch June 19, 2022 06:59
MartinThoma added a commit that referenced this pull request Jun 19, 2022
The highlight of this release is improved support for file encryption
(AES-128 and AES-256, R5 only). See #749 for the amazing work of
@exiledkingcc 🎊 Thank you 🤗

Deprecations (DEP):
-  Rename names to be PEP8-compliant (#967)
  - `PdfWriter.get_page`: the pageNumber parameter is renamed to page_number
  - `PyPDF2.filters`:
    * For all classes, a parameter rename: decodeParms ➔ decode_parms
    * decodeStreamData ➔ decode_stream_data
  - `PyPDF2.xmp`:
    * XmpInformation.rdfRoot ➔ XmpInformation.rdf_root
    * XmpInformation.xmp_createDate ➔ XmpInformation.xmp_create_date
    * XmpInformation.xmp_creatorTool ➔ XmpInformation.xmp_creator_tool
    * XmpInformation.xmp_metadataDate ➔ XmpInformation.xmp_metadata_date
    * XmpInformation.xmp_modifyDate ➔ XmpInformation.xmp_modify_date
    * XmpInformation.xmpMetadata ➔ XmpInformation.xmp_metadata
    * XmpInformation.xmpmm_documentId ➔ XmpInformation.xmpmm_document_id
    * XmpInformation.xmpmm_instanceId ➔ XmpInformation.xmpmm_instance_id
  - `PyPDF2.generic`:
    * readHexStringFromStream ➔ read_hex_string_from_stream
    * initializeFromDictionary ➔ initialize_from_dictionary
    * createStringObject ➔ create_string_object
    * TreeObject.hasChildren ➔ TreeObject.has_children
    * TreeObject.emptyTree ➔ TreeObject.empty_tree

New Features (ENH):
-  Add decrypt support for V5 and AES-128, AES-256 (R5 only) (#749)

Robustness (ROB):
-  Fix corrupted (wrongly) linear PDF (#1008)

Maintenance (MAINT):
-  Move PDF_Samples folder into ressources
-  Fix typos (#1007)

Testing (TST):
-  Improve encryption/decryption test (#1009)
-  Add merger test cases with real PDFs (#1006)
-  Add mutmut config

Code Style (STY):
-  Put pure data mappings in separate files (#1005)
-  Make encryption module private, apply pre-commit (#1010)

Full Changelog: 2.2.1...2.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant