BUG: Add missing deprecated EncodedStreamObject functions #1139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1138
The
EncodedStreamObject
class was missing the deprecatedgetData
andsetData
functions, which would call theget_data
andset_data
functions respectively after issuing a deprecation warning. The original functions were totally renamed in c774ab0. That same commit did properly handle thegetData
andsetData
functions in theDecodedStreamObject
though, where they issue a deprecation warning and then callget_data
andset_data
.This should probably be backported to 1.x where it exists as well, as it should be simple enough, and the user in #1138 is using 1.28.2 and cannot upgrade due to this bug.