Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB : cope with invalid parent xref (#1089) #1133

Merged
merged 1 commit into from Jul 20, 2022

Conversation

pubpub-zz
Copy link
Collaborator

rebuild the xref if the parent chained xref is invalid

rebuild the xref if the parent chained xref is invalid
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1133 (4daade6) into main (f2983e1) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   92.03%   91.94%   -0.10%     
==========================================
  Files          24       24              
  Lines        4671     4679       +8     
  Branches      965      966       +1     
==========================================
+ Hits         4299     4302       +3     
- Misses        227      231       +4     
- Partials      145      146       +1     
Impacted Files Coverage Δ
PyPDF2/_reader.py 90.88% <50.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2983e1...4daade6. Read the comment docs.

@MartinThoma MartinThoma added the is-robustness-issue From a users perspective, this is about robustness label Jul 20, 2022
@MartinThoma MartinThoma merged commit 2abae35 into py-pdf:main Jul 20, 2022
@MartinThoma
Copy link
Member

Oh yes! Nice! I love that we're now capable of dealing with that issue 🥳

Thank you, @pubpub-zz 🤗

MartinThoma added a commit that referenced this pull request Jul 21, 2022
New Features (ENH):
-  Add `outline_count` property (#1129)

Bug Fixes (BUG):
-  Make reader.get_fields also return dropdowns with options (#1114)
-  Add deprecated EncodedStreamObject functions back until PyPDF2==3.0.0 (#1139)

Robustness (ROB):
-  Cope with missing /W entry (#1136)
-  Cope with invalid parent xref (#1133)

Documentation (DOC):
-  Contributors file (#1132)
-  Fix type in signature of PdfWriter.add_uri (#1131)

Developer Experience (DEV):
-  Add .git-blame-ignore-revs (#1141)

Code Style (STY):
-  Fixing typos (#1137)
-  Re-use code via get_outlines_property in tests (#1130)

Full Changelog: 2.6.0...2.7.0
@pubpub-zz pubpub-zz deleted the iss1089 branch August 8, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-robustness-issue From a users perspective, this is about robustness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants