Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add 'threads' property to PdfWriter #1458

Merged
merged 5 commits into from Dec 2, 2022
Merged

Conversation

pubpub-zz
Copy link
Collaborator

NOTE!!!!
this currently returns only an empty list . Peding to PR#1371

this currently returns only an empty list . Pending to  PR#1371
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 94.41% // Head: 94.43% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (66262ba) compared to base (1a9f7d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1458      +/-   ##
==========================================
+ Coverage   94.41%   94.43%   +0.01%     
==========================================
  Files          28       28              
  Lines        5178     5194      +16     
  Branches      982      984       +2     
==========================================
+ Hits         4889     4905      +16     
  Misses        173      173              
  Partials      116      116              
Impacted Files Coverage Δ
PyPDF2/_reader.py 90.30% <100.00%> (+0.06%) ⬆️
PyPDF2/_writer.py 91.65% <100.00%> (+0.11%) ⬆️
PyPDF2/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
ready for merge

@pubpub-zz pubpub-zz mentioned this pull request Nov 29, 2022
@MartinThoma MartinThoma changed the title ENH : add threads access in PdfWriter ENH: Add threads property to PdfWriter Dec 1, 2022
@MartinThoma MartinThoma changed the title ENH: Add threads property to PdfWriter ENH: Add 'threads' property to PdfWriter Dec 1, 2022
@MartinThoma MartinThoma merged commit 3e250c5 into py-pdf:main Dec 2, 2022
MartinThoma added a commit that referenced this pull request Dec 10, 2022
New Features (ENH):
-  Add support to extract gray scale images (#1460)
-  Add 'threads' property to PdfWriter (#1458)
-  Add 'open_destination' property to PdfWriter (#1431)
-  Make PdfReader.get_object accept integer arguments (#1459)

Bug Fixes (BUG):
-  Scale PDF annotations (#1479)

Robustness (ROB):
-  Padding issue with AES encryption (#1469)
-  Accept empty object as null objects (#1477)

Documentation (DOC):
-  Add module documentation the PaperSize class (#1447)

Maintenance (MAINT):
-  Use 'page_number' instead of 'pagenum' (#1365)
-  Add List of pages to PageRangeSpec (#1456)

Testing (TST):
-  Cleanup temporary files (#1454)
-  Mark test_tounicode_is_identity as external (#1449)
-  Use Ubuntu 20.04 for running CI test suite (#1452)

[Full Changelog](2.11.2...2.12.0)
@pubpub-zz pubpub-zz deleted the Threads branch June 24, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants