Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB : accept empty object as null objects #1477

Merged
merged 2 commits into from Dec 8, 2022

Conversation

pubpub-zz
Copy link
Collaborator

fixes #1474

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 93.94% // Head: 94.00% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c962718) compared to base (635f0ca).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
+ Coverage   93.94%   94.00%   +0.05%     
==========================================
  Files          30       30              
  Lines        5438     5441       +3     
  Branches     1035     1036       +1     
==========================================
+ Hits         5109     5115       +6     
+ Misses        199      197       -2     
+ Partials      130      129       -1     
Impacted Files Coverage Δ
PyPDF2/generic/_data_structures.py 95.62% <100.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 7f586ae into py-pdf:main Dec 8, 2022
MartinThoma added a commit that referenced this pull request Dec 10, 2022
New Features (ENH):
-  Add support to extract gray scale images (#1460)
-  Add 'threads' property to PdfWriter (#1458)
-  Add 'open_destination' property to PdfWriter (#1431)
-  Make PdfReader.get_object accept integer arguments (#1459)

Bug Fixes (BUG):
-  Scale PDF annotations (#1479)

Robustness (ROB):
-  Padding issue with AES encryption (#1469)
-  Accept empty object as null objects (#1477)

Documentation (DOC):
-  Add module documentation the PaperSize class (#1447)

Maintenance (MAINT):
-  Use 'page_number' instead of 'pagenum' (#1365)
-  Add List of pages to PageRangeSpec (#1456)

Testing (TST):
-  Cleanup temporary files (#1454)
-  Mark test_tounicode_is_identity as external (#1449)
-  Use Ubuntu 20.04 for running CI test suite (#1452)

[Full Changelog](2.11.2...2.12.0)
@pubpub-zz pubpub-zz deleted the EmptyObj branch June 24, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: read length must be non-negative or -1
2 participants