New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROB: Padding issue with AES encryption #1469
Conversation
Fixes #1221 Credit goes to Alper ahmetoglu for the fix Co-authored-by: Alper Ahmetoglu <ahmetoglu.alper@gmail.com>
Codecov ReportBase: 93.73% // Head: 93.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 93.73% 93.69% -0.04%
==========================================
Files 28 28
Lines 5235 5238 +3
Branches 997 998 +1
==========================================
+ Hits 4907 4908 +1
- Misses 199 200 +1
- Partials 129 130 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@exiledkingcc Does this change make sense to you? |
from PDF reference 1.7, §3.5.1: it looks good to me. A test would be welcomed |
from PDF reference 1.7, §3.5.1: it looks good to me. Just surprise it has not been detected earlier : A test would be welcomed |
i'think the PDF file maybe corrupted. |
@exiledkingcc it shouldn't need it, I thought so as well. But would adding the padding here ever break a non-broken pdf? Maybe it's worth including it for robustness |
New Features (ENH): - Add support to extract gray scale images (#1460) - Add 'threads' property to PdfWriter (#1458) - Add 'open_destination' property to PdfWriter (#1431) - Make PdfReader.get_object accept integer arguments (#1459) Bug Fixes (BUG): - Scale PDF annotations (#1479) Robustness (ROB): - Padding issue with AES encryption (#1469) - Accept empty object as null objects (#1477) Documentation (DOC): - Add module documentation the PaperSize class (#1447) Maintenance (MAINT): - Use 'page_number' instead of 'pagenum' (#1365) - Add List of pages to PageRangeSpec (#1456) Testing (TST): - Cleanup temporary files (#1454) - Mark test_tounicode_is_identity as external (#1449) - Use Ubuntu 20.04 for running CI test suite (#1452) [Full Changelog](2.11.2...2.12.0)
Fixes #1221
Credit goes to Alper ahmetoglu for the fix
Co-authored-by: Alper Ahmetoglu ahmetoglu.alper@gmail.com