Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Improve test coverage by extracting texts #998

Merged
merged 6 commits into from Jun 16, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #998 (5d5b2d8) into main (034d7a9) will increase coverage by 1.93%.
The diff coverage is 100.00%.

❗ Current head 5d5b2d8 differs from pull request most recent head 8500a32. Consider uploading reports for the commit 8500a32 to get more accurate results

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
+ Coverage   85.55%   87.48%   +1.93%     
==========================================
  Files          18       18              
  Lines        4180     4124      -56     
  Branches      886      876      -10     
==========================================
+ Hits         3576     3608      +32     
+ Misses        419      340      -79     
+ Partials      185      176       -9     
Impacted Files Coverage Δ
PyPDF2/_page.py 90.15% <ø> (+7.38%) ⬆️
PyPDF2/_reader.py 83.01% <ø> (+3.54%) ⬆️
PyPDF2/_merger.py 69.93% <100.00%> (ø)
PyPDF2/generic.py 90.97% <0.00%> (+1.27%) ⬆️
PyPDF2/_cmap.py 83.23% <0.00%> (+6.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034d7a9...8500a32. Read the comment docs.

@MartinThoma MartinThoma merged commit 6ce36f7 into main Jun 16, 2022
@MartinThoma MartinThoma deleted the improve-test-coverage branch June 16, 2022 08:55
MartinThoma added a commit that referenced this pull request Jun 17, 2022
Performance Improvements (PI):
-  Remove b_ calls (#992, #986)
-  Apply improvements to _utils suggested by perflint (#993)

Robustness (ROB):
-  utf-16-be\' codec can\'t decode (...) (#995)

Documentation (DOC):
-  Remove reference to Scripts (#987)

Developer Experience (DEV):
-  Fix type annotations for add_bookmarks (#1000)

Testing (TST):
-  Add test for PdfMerger (#1001)
-  Add tests for XMP information (#996)
-  reader.get_fields / zlib issue / LZW decode issue (#1004)
-  reader.get_fields with report generation (#1002)
-  Improve test coverage by extracting texts (#998)

Code Style (STY):
-  Apply fixes suggested by pylint (#999)

Full Changelog: 2.2.0...2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant