Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: reader.get_fields #1004

Merged
merged 5 commits into from Jun 17, 2022
Merged

TST: reader.get_fields #1004

merged 5 commits into from Jun 17, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@MartinThoma MartinThoma changed the title Get fields TST: reader.get_fields Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1004 (ee366e4) into main (a6b66b1) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   88.86%   89.76%   +0.89%     
==========================================
  Files          18       18              
  Lines        4113     4113              
  Branches      870      870              
==========================================
+ Hits         3655     3692      +37     
+ Misses        294      263      -31     
+ Partials      164      158       -6     
Impacted Files Coverage Δ
PyPDF2/generic.py 91.52% <ø> (+0.20%) ⬆️
PyPDF2/_page.py 90.93% <0.00%> (+0.77%) ⬆️
PyPDF2/_cmap.py 84.39% <0.00%> (+1.15%) ⬆️
PyPDF2/filters.py 83.71% <0.00%> (+1.95%) ⬆️
PyPDF2/_reader.py 89.53% <0.00%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b66b1...ee366e4. Read the comment docs.

@MartinThoma MartinThoma marked this pull request as ready for review June 17, 2022 07:46
@MartinThoma MartinThoma merged commit bf8ad45 into main Jun 17, 2022
@MartinThoma MartinThoma deleted the get-fields branch June 17, 2022 07:55
MartinThoma added a commit that referenced this pull request Jun 17, 2022
Performance Improvements (PI):
-  Remove b_ calls (#992, #986)
-  Apply improvements to _utils suggested by perflint (#993)

Robustness (ROB):
-  utf-16-be\' codec can\'t decode (...) (#995)

Documentation (DOC):
-  Remove reference to Scripts (#987)

Developer Experience (DEV):
-  Fix type annotations for add_bookmarks (#1000)

Testing (TST):
-  Add test for PdfMerger (#1001)
-  Add tests for XMP information (#996)
-  reader.get_fields / zlib issue / LZW decode issue (#1004)
-  reader.get_fields with report generation (#1002)
-  Improve test coverage by extracting texts (#998)

Code Style (STY):
-  Apply fixes suggested by pylint (#999)

Full Changelog: 2.2.0...2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant