STY: Apply fixes suggested by pylint #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinThoma
commented
Jun 16, 2022
•
MartinThoma
commented
- Use f-strings: They are IMHO more readable and faster than other formatting options
- Reduce code duplication
- Improvements in type annotations
- Add PyPDF2 help text
MartinThoma
force-pushed
the
pylint
branch
3 times, most recently
from
141c787
to
5212b5f
Compare
* Use f-strings: They are more readable and faster than other
string formatting options
Codecov Report
@@ Coverage Diff @@
## main #999 +/- ##
==========================================
+ Coverage 87.48% 87.55% +0.06%
==========================================
Files 18 18
Lines 4124 4113 -11
Branches 876 870 -6
==========================================
- Hits 3608 3601 -7
+ Misses 340 337 -3
+ Partials 176 175 -1
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
Jun 17, 2022
Performance Improvements (PI): - Remove b_ calls (#992, #986) - Apply improvements to _utils suggested by perflint (#993) Robustness (ROB): - utf-16-be\' codec can\'t decode (...) (#995) Documentation (DOC): - Remove reference to Scripts (#987) Developer Experience (DEV): - Fix type annotations for add_bookmarks (#1000) Testing (TST): - Add test for PdfMerger (#1001) - Add tests for XMP information (#996) - reader.get_fields / zlib issue / LZW decode issue (#1004) - reader.get_fields with report generation (#1002) - Improve test coverage by extracting texts (#998) Code Style (STY): - Apply fixes suggested by pylint (#999) Full Changelog: 2.2.0...2.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.