-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indent HTML lists correctly (Issue 1073) #1170
Commits on May 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f794193 - Browse repository at this point
Copy the full SHA f794193View commit details -
Some debugging and polish needed.
Configuration menu - View commit details
-
Copy full SHA for 20c035e - Browse repository at this point
Copy the full SHA 20c035eView commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb93711 - Browse repository at this point
Copy the full SHA eb93711View commit details
Commits on May 11, 2024
-
Some variables need tweaking. Needs testing. Code reuse unsatisfactory.
Configuration menu - View commit details
-
Copy full SHA for f8f17a5 - Browse repository at this point
Copy the full SHA f8f17a5View commit details -
Some variables need tweaking. Needs testing. Code reuse unsatisfactory.
Configuration menu - View commit details
-
Copy full SHA for 77a1a31 - Browse repository at this point
Copy the full SHA 77a1a31View commit details
Commits on May 12, 2024
-
Potentially significant issues with tests: 1. test_html_ln_outside_p - IndexError: list index out of range. 2. test_html_ol_ul_line_height - actual distance between lines differs slightly from expected. Code reuse unsatisfactory.
Configuration menu - View commit details
-
Copy full SHA for e80d8d9 - Browse repository at this point
Copy the full SHA e80d8d9View commit details -
Need feedback for handling <dd> and <blockquote>. Potentially significant issues with tests: 1. test_html_ol_ul_line_height - actual distance between lines differs slightly from expected. Need feedback for whether or not the new indentation that contradicts old tests is satisfactory. Code reuse unsatisfactory. Need feedback.
Configuration menu - View commit details
-
Copy full SHA for 9bddeca - Browse repository at this point
Copy the full SHA 9bddecaView commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dbcce1f - Browse repository at this point
Copy the full SHA dbcce1fView commit details
Commits on May 16, 2024
-
Bug present: bullets are made one per line instead of one per paragraph. Saving progress before introducing a `Bullet` class.
Configuration menu - View commit details
-
Copy full SHA for fb59849 - Browse repository at this point
Copy the full SHA fb59849View commit details -
Feature implemented. Testing and adjustments of tests needed.
Configuration menu - View commit details
-
Copy full SHA for bc1fab8 - Browse repository at this point
Copy the full SHA bc1fab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d487f7d - Browse repository at this point
Copy the full SHA d487f7dView commit details
Commits on May 17, 2024
-
Added the
li_pseudo_margin
attribute toHTML2FPDF
.Prevented from `Paragraph.top_margin` being added to `pdf.y` of first lines of paragraphs with bullets.
Configuration menu - View commit details
-
Copy full SHA for 2caa750 - Browse repository at this point
Copy the full SHA 2caa750View commit details -
Added the
list_pseudo_margin
attribute toHTML2FPDF
.Prevented from `Paragraph.top_margin` being added to `pdf.y` of first lines of paragraphs with bullets. `<ul>` and `<ol>` tags now cause a creation of a paragraph with the string `\n` being used to generate a fragment of the height `list_pseudo_margin`. Adjusted defaults for `li_tag_indent`.
Configuration menu - View commit details
-
Copy full SHA for ceaa6d3 - Browse repository at this point
Copy the full SHA ceaa6d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 070a41d - Browse repository at this point
Copy the full SHA 070a41dView commit details
Commits on May 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ab204e - Browse repository at this point
Copy the full SHA 4ab204eView commit details -
Fixed the inappropriate
TextMode
importation.Changed `Paragraph.generate_bullet_frag()` into `generate_bullet_frag_and_tl`, and made it also generate the bullet text line. Dealing with the issue of inappropriately large distance between `<dt>` and their child `<dd>` elements when `Paragraph.top_margin` is 0.
Configuration menu - View commit details
-
Copy full SHA for 7b8923c - Browse repository at this point
Copy the full SHA 7b8923cView commit details -
Fixed the inappropriate
TextMode
importation.Changed `Paragraph.generate_bullet_frag()` into `generate_bullet_frag_and_tl`, and made it also generate the bullet text line.
Configuration menu - View commit details
-
Copy full SHA for 1e1eb29 - Browse repository at this point
Copy the full SHA 1e1eb29View commit details -
Merge remote-tracking branch 'origin/issue_1073' into issue_1073
# Conflicts: # fpdf/html.py
Configuration menu - View commit details
-
Copy full SHA for dc3d8f8 - Browse repository at this point
Copy the full SHA dc3d8f8View commit details
Commits on May 20, 2024
-
Introduced new test
test_html_long_list_entries
.Adjusted old tests.
Configuration menu - View commit details
-
Copy full SHA for 3f56811 - Browse repository at this point
Copy the full SHA 3f56811View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce7cb9b - Browse repository at this point
Copy the full SHA ce7cb9bView commit details
Commits on May 25, 2024
-
Changed the name of the relevant variables from
list_top_margin
to ……`list_vertical_margin`. Removed the `MultiLineBreak.indent` attribute. Added a test for long `<ol>` bullets.
Configuration menu - View commit details
-
Copy full SHA for 24626f9 - Browse repository at this point
Copy the full SHA 24626f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 208e3b3 - Browse repository at this point
Copy the full SHA 208e3b3View commit details -
Merge branch 'refs/heads/master' into issue_1073
# Conflicts: # CHANGELOG.md
Configuration menu - View commit details
-
Copy full SHA for 8cceb1d - Browse repository at this point
Copy the full SHA 8cceb1dView commit details -
Added
self.pdf.normalize_text(bullet_string)
to `Paragraph.generate……_bullet_frag_and_tl`.
Configuration menu - View commit details
-
Copy full SHA for bf5f0fa - Browse repository at this point
Copy the full SHA bf5f0faView commit details -
Added
self.pdf.normalize_text(bullet_string)
to `Paragraph.generate……_bullet_frag_and_tl`.
Configuration menu - View commit details
-
Copy full SHA for 82fbfda - Browse repository at this point
Copy the full SHA 82fbfdaView commit details -
Merge remote-tracking branch 'origin/issue_1073' into issue_1073
# Conflicts: # fpdf/text_region.py
Configuration menu - View commit details
-
Copy full SHA for a75a948 - Browse repository at this point
Copy the full SHA a75a948View commit details -
Adjusted handling of
fragment
s in the `Paragraph.generate_bullet_fr……ags_and_tl` method and in the `Bullet` class.
Configuration menu - View commit details
-
Copy full SHA for fc38846 - Browse repository at this point
Copy the full SHA fc38846View commit details
Commits on May 26, 2024
-
Edited `TextRegion.md` to reflect the introduced changes for `Paragraph`s. Added tests for `Paragraph` generation in `test_html.py`
Configuration menu - View commit details
-
Copy full SHA for 2f69001 - Browse repository at this point
Copy the full SHA 2f69001View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7908e4 - Browse repository at this point
Copy the full SHA f7908e4View commit details
Commits on May 27, 2024
-
Merge branch 'refs/heads/master' into issue_1073
# Conflicts: # CHANGELOG.md # test/html/html_features.pdf
Configuration menu - View commit details
-
Copy full SHA for 5afb935 - Browse repository at this point
Copy the full SHA 5afb935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7118b - Browse repository at this point
Copy the full SHA 4e7118bView commit details
Commits on May 31, 2024
-
Introduced conversion of 'magic numbers', and default tag indent and …
…margin values in `html.py` to the chosen document unit of measurement. Adjusted default tag indent values. Moved the `Paragraph` docstring to the `ParagraphCollectorMixin.paragraph()` method. Changed the `CustomPDF` class in `test_html_customize_ul` to have non-static attributes `li_tag_indent` and `ul_bullet_char`. Adjusted tests.
Configuration menu - View commit details
-
Copy full SHA for 1ead6a3 - Browse repository at this point
Copy the full SHA 1ead6a3View commit details
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 619c250 - Browse repository at this point
Copy the full SHA 619c250View commit details -
Introduced unit conversion for
li_tag_indent
.Minor changes to HTML contents of `test_html_measurement_units()`.
Configuration menu - View commit details
-
Copy full SHA for 418f213 - Browse repository at this point
Copy the full SHA 418f213View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6c8d8b - Browse repository at this point
Copy the full SHA c6c8d8bView commit details -
Renamed
bullet_rel_x_displacement
,bullet_rel_y_displacement
and ……associated class attributes and docstring mentions to `bullet_r_margin`, `bullet_t_margin`, `bullet.r_margin`, `bullet.t_margin`.
Configuration menu - View commit details
-
Copy full SHA for 18dddd7 - Browse repository at this point
Copy the full SHA 18dddd7View commit details -
Undone changes to handling non-default values for
li_tag_indent
and…… `dd_tag_indent` in `html.py`.
Configuration menu - View commit details
-
Copy full SHA for b345631 - Browse repository at this point
Copy the full SHA b345631View commit details
Commits on Jun 9, 2024
-
Requested changes to conversion of default values implemented.
`bullet_t_margin` and associated variables removed. `li_tag_indent` and `dd_tag_indent` default values are changed to None. Changes to `test_html_measurement_units` not included.
Configuration menu - View commit details
-
Copy full SHA for fb3305b - Browse repository at this point
Copy the full SHA fb3305bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc7f247 - Browse repository at this point
Copy the full SHA cc7f247View commit details
Commits on Jun 11, 2024
-
Added `test_html_list_vertical_margin`. Fixed the non-assignment of `HTML2FPDF.list_vertical_margin` when the constructor argument `list_vertical_margin` is not None.
Configuration menu - View commit details
-
Copy full SHA for 37a8d81 - Browse repository at this point
Copy the full SHA 37a8d81View commit details
Commits on Jun 12, 2024
-
Added the 'bullet_r_margin' parameter to `ParagraphCollectorMixin.par…
…agraph()`. Updated relevant docstring and `TextRegion.md` documentation. Adjusted `test_bulleted_paragraphs` to remove mentions of `rel_y_displacement`, changed instances of string `"rel_x_displacement"` to `bullet_r_margin` and introduced usage of `case["bullet_r_margin"]` in the test.
Configuration menu - View commit details
-
Copy full SHA for f6eb85b - Browse repository at this point
Copy the full SHA f6eb85bView commit details
Commits on Jun 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d847eb8 - Browse repository at this point
Copy the full SHA d847eb8View commit details
Commits on Jun 15, 2024
-
Merge branch 'refs/heads/master' into issue_1073
# Conflicts: # test/html/html_customize_ul.pdf # test/html/test_html.py
Configuration menu - View commit details
-
Copy full SHA for 14ddcc4 - Browse repository at this point
Copy the full SHA 14ddcc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 691ad2b - Browse repository at this point
Copy the full SHA 691ad2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c475ab - Browse repository at this point
Copy the full SHA 2c475abView commit details