New embed_file() & file_attachment_annotation() methods #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-C
force-pushed
the
file-attachments
branch
5 times, most recently
from
cf552c7
to
5a2c5f9
Compare
Lucas-C
force-pushed
the
file-attachments
branch
from
5a2c5f9
to
e094c01
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 92.13% 91.97% -0.16%
==========================================
Files 23 23
Lines 6697 6664 -33
Branches 1373 1366 -7
==========================================
- Hits 6170 6129 -41
- Misses 299 304 +5
- Partials 228 231 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lucas-C
changed the title
Lucas-C
force-pushed
the
file-attachments
branch
from
bd75f4b
to
1567a58
Compare
|
This has been released in v2.5.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
The GitHub pipeline is OK (green), meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.