Removing open() & close() methods, that were only used internally…
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.07% // Head: 94.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 94.07% 94.06% -0.02%
==========================================
Files 21 21
Lines 6124 6113 -11
Branches 1250 1249 -1
==========================================
- Hits 5761 5750 -11
Misses 189 189
Partials 174 174
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
… and should never have been called by end-user code
Lucas-C
force-pushed
the
removing-open-remove-methods
branch
from
eaef4d3
to
bf07fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and should never have been called by end-user code