Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Chart Using PyGal added #762

Merged
merged 3 commits into from
Apr 12, 2023
Merged

DOC: Chart Using PyGal added #762

merged 3 commits into from
Apr 12, 2023

Conversation

ssavi-ict
Copy link

@ssavi-ict ssavi-ict commented Apr 10, 2023

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@ssavi-ict ssavi-ict requested a review from Lucas-C as a code owner April 10, 2023 19:04
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f3dadb3) 92.67% compared to head (4f81870) 92.67%.

❗ Current head 4f81870 differs from pull request most recent head 6c9d225. Consider uploading reports for the commit 6c9d225 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #762   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files          27       27           
  Lines        7275     7275           
  Branches     1317     1317           
=======================================
  Hits         6742     6742           
  Misses        337      337           
  Partials      196      196           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/Maths.md Outdated Show resolved Hide resolved
docs/Maths.md Outdated Show resolved Hide resolved
docs/Maths.md Show resolved Hide resolved
docs/Maths.md Outdated Show resolved Hide resolved
docs/Maths.md Show resolved Hide resolved
docs/Maths.md Outdated Show resolved Hide resolved
docs/Maths.md Outdated Show resolved Hide resolved
docs/Maths.md Show resolved Hide resolved
@py-pdf py-pdf deleted a comment from allcontributors bot Apr 11, 2023
docs/Maths.md Outdated Show resolved Hide resolved
@ssavi-ict
Copy link
Author

@Lucas-C , the latest commit did not pass all the checks. Could not understand why it happened. Can you please guide me?

@Lucas-C
Copy link
Member

Lucas-C commented Apr 12, 2023

@Lucas-C , the latest commit did not pass all the checks. Could not understand why it happened. Can you please guide me?

It was nothing serious, there must have been a bit of heavy load on GitHub Actions runners and our performance tests failed to pass the configured execution time threshold. Re-running the failed tests should fix this.

It has nothing to do with the content of your PR, so you really don't have to bother 😊

@Lucas-C Lucas-C merged commit 393580e into py-pdf:master Apr 12, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Apr 12, 2023

Merged!
Thank you very much for your contribution @ssavi-ict 😊

@ssavi-ict
Copy link
Author

ssavi-ict commented Apr 12, 2023

Thank You @Lucas-C . It is my absolute pleasure. I am intended to do more contribution. And hopefully I can do that.

Just to let you know, there are some links broken like this one. There are some other unbroken links present. I would like to raise a PR fixing this issue.

@Lucas-C
Copy link
Member

Lucas-C commented Apr 12, 2023

Thank You @Lucas-C . It is my absolute pleasure. I am intended to do more contribution. And hopefully I can do that.

You would be very welcome!

Also, if you have suggestions to improve the library, please share them 😊

Just to let you know, there are some links broken like this one. There are some other unbroken links present. I would like to raise a PR fixing this issue.

Oh you men on this page? https://pyfpdf.github.io/fpdf2/index.html#tutorials
You are absolutely right. I renamed some tutorial files in f9cf1b1 but I think I forgot to update some links in docs/index.md. A PR fixing that would be very welcome!

@Lucas-C
Copy link
Member

Lucas-C commented Apr 12, 2023

By the way, the documentation section you added is now public!
https://pyfpdf.github.io/fpdf2/Maths.html#using-pygal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: provide an usage example of combining fpdf2 with Pygal
3 participants