Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Link Fixes #765

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Broken Link Fixes #765

merged 7 commits into from
Apr 12, 2023

Conversation

ssavi-ict
Copy link

e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@ssavi-ict ssavi-ict requested a review from Lucas-C as a code owner April 12, 2023 16:36
Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ssavi-ict!

@Lucas-C
Copy link
Member

Lucas-C commented Apr 12, 2023

Could you also include in this PR the fixes for the broken tutorial links in docs/index.md, please? 😊
https://pyfpdf.github.io/fpdf2/index.html#tutorials

@ssavi-ict
Copy link
Author

@Lucas-C , the first broken link I noticed was this one. Later I forgot where I have seen that. Thanks for noticing this issue. Edited accordingly.

docs/index.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.47 🎉

Comparison is base (393580e) 92.67% compared to head (0394062) 93.15%.

❗ Current head 0394062 differs from pull request most recent head 6141a39. Consider uploading reports for the commit 6141a39 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   92.67%   93.15%   +0.47%     
==========================================
  Files          27       27              
  Lines        7275     7288      +13     
  Branches     1317     1322       +5     
==========================================
+ Hits         6742     6789      +47     
+ Misses        337      312      -25     
+ Partials      196      187       -9     
Impacted Files Coverage Δ
fpdf/fpdf.py 92.26% <100.00%> (+0.01%) ⬆️
fpdf/html.py 93.06% <100.00%> (+5.44%) ⬆️
fpdf/image_parsing.py 83.77% <100.00%> (+0.14%) ⬆️
fpdf/table.py 90.99% <100.00%> (+6.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssavi-ict
Copy link
Author

ssavi-ict commented Apr 12, 2023

@Lucas-C , Will it be good if we mention when a translator would like to translate in his/her own language (s)he needs to -

  • Reflect the changes into index.md, CHANGELOG.md, README.md, mkdocs.yml files with line numbers or section notation.
  • The translation file name should be written in English letter.

Maybe you can edit issue #267 with some guidelines like this.
This will be helpful for an OPEN SOURCE beginner like me.

@Lucas-C Lucas-C merged commit af8c653 into py-pdf:master Apr 12, 2023
@Lucas-C
Copy link
Member

Lucas-C commented Apr 12, 2023

@Lucas-C , Will it be good if we mention when a translator would like to translate in his/her own language (s)he needs to -

  • Reflect the changes into index.md, CHANGELOG.md, README.md, mkdocs.yml files with line numbers or section notation.
  • The translation file name should be written in English letter.

Maybe you can edit issue #267 with some guidelines like this. This will be helpful for an OPEN SOURCE beginner like me.

Excellent idea!
I have just done so 😊

@ssavi-ict
Copy link
Author

Excellent idea! I have just done so 😊

Great. Thank You ...

@ssavi-ict ssavi-ict deleted the refactor branch April 12, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants