Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: table gutter #787

Merged
merged 2 commits into from
May 31, 2023
Merged

New feature: table gutter #787

merged 2 commits into from
May 31, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented May 17, 2023

DocPreview-Tables-with-gutter

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4afcf4c) 93.28% compared to head (31ba5d2) 93.29%.

❗ Current head 31ba5d2 differs from pull request most recent head ced1763. Consider uploading reports for the commit ced1763 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   93.28%   93.29%           
=======================================
  Files          27       27           
  Lines        7347     7355    +8     
  Branches     1329     1331    +2     
=======================================
+ Hits         6854     6862    +8     
  Misses        309      309           
  Partials      184      184           
Impacted Files Coverage Δ
fpdf/fpdf.py 92.54% <100.00%> (ø)
fpdf/table.py 92.55% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucas-C
Copy link
Member Author

Lucas-C commented May 23, 2023

@gmischler @MartinThoma: would you like to review this new feature?

I'd be happy to have you opinion on this😊

@kuth-chi
Copy link

Great to get this.

@Lucas-C
Copy link
Member Author

Lucas-C commented May 31, 2023

OK I'm merginh this

@Lucas-C Lucas-C merged commit 4827901 into master May 31, 2023
10 checks passed
@Lucas-C Lucas-C deleted the table-gutter branch May 31, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants