Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and tests for colspan #807

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Conversation

RubendeBruin
Copy link

@RubendeBruin RubendeBruin commented Jun 7, 2023

Added test and documentation for colspan

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md --> No change to code, not added to changelog

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@Lucas-C
Copy link
Member

Lucas-C commented Jun 7, 2023

@allcontributors please add @RubendeBruin for documentation

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @RubendeBruin! 🎉

@Lucas-C
Copy link
Member

Lucas-C commented Jun 7, 2023

Could you please rebase this PR?

@RubendeBruin
Copy link
Author

I think I just rebased it.

@Lucas-C Lucas-C merged commit e8d6257 into py-pdf:master Jun 11, 2023
11 checks passed
@Lucas-C
Copy link
Member

Lucas-C commented Jun 11, 2023

Merged, thank you @RubendeBruin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants