Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve dash pattern on new page, fix #992 #993

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

gmischler
Copy link
Collaborator

Fixes #992

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.
  • A unit test is covering the code added / modified by this PR
  • This PR is ready to be merged
  • [NA] In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder
  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fb9fd9c) 93.79% compared to head (377ec38) 93.79%.

❗ Current head 377ec38 differs from pull request most recent head e79cf54. Consider uploading reports for the commit e79cf54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          28       28           
  Lines        8391     8396    +5     
  Branches     1544     1545    +1     
=======================================
+ Hits         7870     7875    +5     
  Misses        323      323           
  Partials      198      198           
Files Coverage Δ
fpdf/fpdf.py 93.06% <100.00%> (+0.01%) ⬆️
fpdf/line_break.py 99.14% <100.00%> (ø)
fpdf/graphics_state.py 98.78% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmischler gmischler merged commit d81018d into py-pdf:master Nov 1, 2023
10 checks passed
@gmischler gmischler deleted the new_page_graphics_state branch November 1, 2023 12:26
@Lucas-C
Copy link
Member

Lucas-C commented Nov 2, 2023

Thank you and good job on this @gmischler 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_dash_pattern fails under certain conditions
3 participants