Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB : fix decryt returning empty bytestring #1258

Merged
merged 2 commits into from Aug 21, 2022

Conversation

pubpub-zz
Copy link
Collaborator

fix #1245

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #1258 (330a210) into main (baf0de1) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
- Coverage   94.89%   94.85%   -0.04%     
==========================================
  Files          30       30              
  Lines        4971     4973       +2     
  Branches     1022     1023       +1     
==========================================
  Hits         4717     4717              
- Misses        142      143       +1     
- Partials      112      113       +1     
Impacted Files Coverage Δ
PyPDF2/_encryption.py 92.62% <33.33%> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pubpub-zz pubpub-zz closed this Aug 20, 2022
@pubpub-zz pubpub-zz deleted the feature/iss1245 branch August 20, 2022 14:19
@pubpub-zz
Copy link
Collaborator Author

@MartinThoma,
I've closed this PR by error can you reopen it and merge it if it is ok for you

@pubpub-zz pubpub-zz restored the feature/iss1245 branch August 21, 2022 07:45
@pubpub-zz pubpub-zz reopened this Aug 21, 2022
@pubpub-zz
Copy link
Collaborator Author

Hiha ! I managed to reopen it by myself

@MartinThoma MartinThoma merged commit cf3aab4 into py-pdf:main Aug 21, 2022
@MartinThoma
Copy link
Member

Thank you @pubpub-zz 🙏 I'll release it today.

As a side-note: I'll be on vacation the next week, so I might not respond.

@pubpub-zz
Copy link
Collaborator Author

Enjoy ! 😎

MartinThoma added a commit that referenced this pull request Aug 21, 2022
Robustness (ROB):
-  Decrypt returns empty bytestring (#1258)

Documentation (DOC):
-  Adding WevertonGomes as a Contributor

Developer Experience (DEV):
-  Modify CI to better verify built package contents (#1244)

Maintenance (MAINT):
-  Remove unused sign function in _extract_text (#1262)
-  Remove \'mine\' as PdfMerger always creates the stream (#1261)
-  Let PdfMerger._create_stream raise NotImplemented (#1251)
-  password param of _security._alg32(...) is only a string, not bytes (#1259)
-  Remove unreachable code in read_block_backwards (#1250)

Testing (TST):
-  Delete annotations (#1263)
-  Close PdfMerger in tests (#1260)
-  PdfReader.xmp_metadata workflow (#1257)
-  Various PdfWriter (Layout, Bookmark deprecation) (#1249)

Full Changelog: 2.10.2...2.10.3
@pubpub-zz pubpub-zz deleted the feature/iss1245 branch September 3, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: index out of range when encountering a digital certificate/signature
2 participants