Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Throw PdfReadError if Trailer can't be read #1298

Merged
merged 11 commits into from Aug 31, 2022
Merged

MAINT: Throw PdfReadError if Trailer can't be read #1298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c3fbdcf
Added PdfReadError in cases where trailer is absent of can't be read.…
ediamondscience Aug 29, 2022
50e1813
Update PyPDF2/_reader.py
ediamondscience Aug 30, 2022
b3d24c6
Added test for unreadable metadata and pdf file unreadablemetadata.pd…
ediamondscience Aug 30, 2022
e953636
Update PyPDF2/_reader.py
MartinThoma Aug 30, 2022
584bea6
Clarified which exception should be thrown for unreadble metadata to …
ediamondscience Aug 30, 2022
648bbb1
Updated reader test code to move unreadable meta data file to sample …
ediamondscience Aug 30, 2022
a1733b4
Merge branch 'main' of https://github.com/ediamondscience/PyPDF2
ediamondscience Aug 30, 2022
40a6ea7
Merge branch 'main' into main
MartinThoma Aug 30, 2022
35bb613
Removed unreadable metadata from ./resources folder
ediamondscience Aug 30, 2022
820afd8
Merge branch 'main' of https://github.com/ediamondscience/PyPDF2
ediamondscience Aug 30, 2022
4f31b64
Merge branch 'main' into main
MartinThoma Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@ history and [GitHubs 'Contributors' feature](https://github.com/py-pdf/PyPDF2/gr
## Contributors to the pyPdf / PyPDF2 project

* [DL6ER](https://github.com/DL6ER)
* [ediamondscience](https://github.com/ediamondscience)
* [JianzhengLuo](https://github.com/JianzhengLuo)
* [Karvonen, Harry](https://github.com/Hatell/)
* [KourFrost](https://github.com/KourFrost)
Expand Down
7 changes: 5 additions & 2 deletions PyPDF2/_reader.py
View file
Open in desktop
Expand Up @@ -326,8 +326,11 @@ def metadata(self) -> Optional[DocumentInformation]:
return None
obj = self.trailer[TK.INFO]
retval = DocumentInformation()
retval.update(obj) # type: ignore
return retval
if isinstance(obj, type(None)) is True:
ediamondscience marked this conversation as resolved.
Show resolved Hide resolved
raise PdfReadError("trailer not found or does not point to document information directory")
else:
retval.update(obj) # type: ignore
return retval
MartinThoma marked this conversation as resolved.
Show resolved Hide resolved

def getDocumentInfo(self) -> Optional[DocumentInformation]: # pragma: no cover
"""
Expand Down