Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Remove erroneous assertion check #1564

Merged
merged 5 commits into from
Jan 21, 2023
Merged

BUG: Remove erroneous assertion check #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b01b7f
remove erroneous assertion check
pubpub-zz Jan 18, 2023
d39988a
flake8
pubpub-zz Jan 18, 2023
b7f7a19
flake8
pubpub-zz Jan 20, 2023
222a782
add test
pubpub-zz Jan 20, 2023
2d00b3c
Merge branch 'main' into iss1559
pubpub-zz Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pypdf/_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,11 +1901,11 @@ def _read_xref_subsections(
get_entry: Callable[[int], Union[int, Tuple[int, ...]]],
used_before: Callable[[int, Union[int, Tuple[int, ...]]], bool],
) -> None:
last_end = 0
# last_end = 0
for start, size in self._pairs(idx_pairs):
# The subsections must increase
assert start >= last_end
last_end = start + size
# assert start >= last_end
# last_end = start + size
for num in range(start, start + size):
# The first entry is the type
xref_type = get_entry(0)
Expand Down
8 changes: 8 additions & 0 deletions tests/test_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,3 +1279,11 @@ def test_build_outline_item(caplog):
def test_page_labels(src, page_labels):
max_indices = 6
assert PdfReader(src).page_labels[:max_indices] == page_labels[:max_indices]


def test_iss1559():
url = "https://github.com/py-pdf/pypdf/files/10441992/default.pdf"
name = "iss1559.pdf"
reader = PdfReader(BytesIO(get_pdf_from_url(url, name=name)))
for p in reader.pages:
p.extract_text()