Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Deprecation warnings/errors #1794

Merged
merged 2 commits into from
Apr 16, 2023
Merged

TST: Deprecation warnings/errors #1794

merged 2 commits into from
Apr 16, 2023

Conversation

MartinThoma
Copy link
Member

@MartinThoma MartinThoma commented Apr 16, 2023

BUG: deprecate_with_replacement was potentially giving the wrong error message (version 3.0.0 instead of the actual version)

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (86502b9) 93.12% compared to head (a24c852) 93.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
+ Coverage   93.12%   93.16%   +0.04%     
==========================================
  Files          34       34              
  Lines        6616     6616              
  Branches     1304     1304              
==========================================
+ Hits         6161     6164       +3     
+ Misses        298      295       -3     
  Partials      157      157              
Impacted Files Coverage Δ
pypdf/_utils.py 98.97% <100.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 0800361 into main Apr 16, 2023
@MartinThoma MartinThoma deleted the tst-deprecation-warning branch April 16, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant