STY: Same attributes between PdfReader and PdfWriter #1870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provides the same interface to access root,info,id for communalisation
the interface should be public
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 93.42% 93.54% +0.11%
==========================================
Files 34 34
Lines 6634 6627 -7
Branches 1303 1297 -6
==========================================
+ Hits 6198 6199 +1
+ Misses 284 281 -3
+ Partials 152 147 -5
☔ View full report in Codecov by Sentry. |
|
@pubpub-zz This PR is open for quite a while. Is it still relevant? |
|
Yes I need to complete it a little to isolate some common code : this will ease maintenance and allow to get some PdfReader only functions into PdfWriter |
|
No problem. I didn't intend to put pressure on you. I just wanted to ensure that I don't forget PRs :-) |
MartinThoma
changed the title
|
closed : rewritten in #2495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provides the same interface to access root,info,id for communalisation
The objective is prepare some code factorization between PdfWriter / PdfReader