BUG: Prevent updating page contents after merging page (stamping/watermarking) #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add also over param in merge_page closes py-pdf#1951
pubpub-zz
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 33 33
Lines 6993 6996 +3
Branches 1386 1388 +2
=======================================
+ Hits 6569 6572 +3
Misses 273 273
Partials 151 151
☔ View full report in Codecov by Sentry. |
|
@MartinThoma |
MartinThoma
changed the title
|
Thank you! I'll check it today, but it might be in the evening :-) |
MartinThoma
reviewed
Jul 9, 2023
MartinThoma
reviewed
Jul 9, 2023
MartinThoma
reviewed
Jul 9, 2023
Co-authored-by: Martin Thoma <info@martin-thoma.de>
Co-authored-by: Martin Thoma <info@martin-thoma.de>
MartinThoma
reviewed
Jul 9, 2023
pypdf/_page.py
Outdated
| @@ -972,7 +977,9 @@ def replace_contents( | |||
| # this will be fixed with the _add_object | |||
| self[NameObject(PG.CONTENTS)] = content | |||
|
|
|||
| def merge_page(self, page2: "PageObject", expand: bool = False) -> None: | |||
| def merge_page( | |||
| self, page2: "PageObject", over: bool = True, expand: bool = False | |||
There was a problem hiding this comment.
Suggested change
| self, page2: "PageObject", over: bool = True, expand: bool = False | |
| self, page2: "PageObject", expand: bool = False, over: bool = True |
MartinThoma
added a commit
that referenced
this pull request
Jul 9, 2023
Bug Fixes (BUG): - Prevent updating page contents after merging page (stamping/watermarking) (#1952) - % to be hex encoded in names (#1958) - Inverse color in CMYK images (#1947) - Dates conversion not working with Z00\'00\' (#1946) - Support UTF-16-LE Strings (#1884) [Full Changelog](3.12.0...3.12.1)
MartinThoma
added a commit
that referenced
this pull request
Jul 9, 2023
Bug Fixes (BUG): - Prevent updating page contents after merging page (stamping/watermarking) (#1952) - % to be hex encoded in names (#1958) - Inverse color in CMYK images (#1947) - Dates conversion not working with Z00\'00\' (#1946) - Support UTF-16-LE Strings (#1884) [Full Changelog](3.12.0...3.12.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add also over param in merge_page
closes #1951
closes #1953