Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Handle indirect objects as parameters for CCITTFaxDecode #2307

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

stefan6419846
Copy link
Collaborator

@stefan6419846 stefan6419846 commented Nov 24, 2023

While doing some error analysis, I stumbled upon the following error:

[...]
    if CCITT.COLUMNS in parameters:
TypeError: argument of type 'IndirectObject' is not iterable

This resolves the error. Unfortunately, I do not have any public test document at the moment which I could share here or privately.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22eee75) 94.39% compared to head (62ba6e4) 94.39%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2307   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          43       43           
  Lines        7654     7655    +1     
  Branches     1513     1513           
=======================================
+ Hits         7225     7226    +1     
  Misses        266      266           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pypdf/filters.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma merged commit 441bb59 into py-pdf:main Nov 28, 2023
14 checks passed
@MartinThoma
Copy link
Member

@stefan6419846 Thank you for the fix 🙏
@pubpub-zz thank you for the review 🤗

@stefan6419846 stefan6419846 deleted the ccittfaxdcode branch November 29, 2023 07:34
MartinThoma added a commit that referenced this pull request Dec 10, 2023
## What's new

### Bug Fixes (BUG)
-  Cope with deflated images with CMYK Black Only (#2322) by @pubpub-zz
-  Handle indirect objects as parameters for CCITTFaxDecode (#2307) by @stefan6419846
-  check words length in _cmap type1_alternative function (#2310) by @Takher

### Robustness (ROB)
-  Relax flate decoding for too many lookup values (#2331) by @stefan6419846
-  Let _build_destination skip in case of missing /D key (#2018) by @nickryand

### Documentation (DOC)
-  Note in reading form data (#2338) by @MartinThoma
-  Pull Request prefixes and size by @MartinThoma
-  Add https://github.com/zuypt for #2325 as a contributor by @MartinThoma
-  Fix docstring for RunLengthDecode.decode (#2302) by @stefan6419846

### Maintenance (MAINT)
-  Enable `disallow_any_generics` and add missing generics (#2278) by @nilehmann

### Testing (TST)
-  Centralize file downloads (#2324) by @MartinThoma

### Code Style (STY)
-  Fix typo "steam" \xe2\x86\x92 "stream" (#2327) by @stefan6419846
-  Run black by @MartinThoma
-  Make Traceback in bug report template uppercase (#2304) by @stefan6419846

[Full Changelog](3.17.1...3.17.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants