Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling name without leading / #2373

Closed
wants to merge 2 commits into from
Closed

handling name without leading / #2373

wants to merge 2 commits into from

Conversation

Rak424
Copy link
Contributor

@Rak424 Rak424 commented Dec 27, 2023

Leading slash is not part of the Name value, but only required in binary representation, so it should not be needed for Name object creation.

From spec:

When writing a name in a PDF file, a SOLIDUS (2Fh) (/) shall be used to introduce a name. The SOLIDUS is not part of the name but is a prefix indicating that what follows is a sequence of characters representing the name in the PDF file and shall follow these rules:

@stefan6419846
Copy link
Collaborator

Thanks for the PR. Please follow the usual naming scheme for your contribution: https://pypdf.readthedocs.io/en/latest/dev/intro.html#commit-messages And do you have a corresponding example PDF file (or can generate one) which can be used to add a corresponding test as well?

@Rak424 Rak424 deleted the branch py-pdf:main December 27, 2023 14:52
@Rak424 Rak424 closed this Dec 27, 2023
@Rak424 Rak424 deleted the main branch December 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants