DEV: add _get_page_number_from_indirect in writer

[pubpub-zz]

create similar function to have same API as in reader used in future dev

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (afbee38) to head (d8f5f3a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2493   +/-   ##
=======================================
  Coverage   94.46%   94.47%           
=======================================
  Files          49       49           
  Lines        8058     8067    +9     
  Branches     1625     1628    +3     
=======================================
+ Hits         7612     7621    +9     
  Misses        276      276           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefan6419846]

@pubpub-zz Could you please have a look at what went wrong with your PR? GitHub states that there have been over 5000 changed lines, which is incorrect as Meld just states a basic subset:

    def _get_page_number_by_indirect(
        self, indirect_reference: Union[None, int, NullObject, IndirectObject]
    ) -> Optional[int]:
        """
        Generate _page_id2num.

        Args:
            indirect_reference:

        Returns:
            The page number or None
        """
        # to provide same function as in PdfReader
        if indirect_reference is None or isinstance(indirect_reference, NullObject):
            return None
        if isinstance(indirect_reference, int):
            indirect_reference = IndirectObject(indirect_reference, 0, self)
        obj = indirect_reference.get_object()
        if isinstance(obj, PageObject):
            return obj.page_number
        else:
            return None

def test_get_pagenumber_from_indirectobject():
    """
    Test Reattach function
    addressed in #2453
    """
    pdf_path = RESOURCE_ROOT / "crazyones.pdf"
    writer = PdfWriter(clone_from=pdf_path)
    assert writer._get_page_number_by_indirect(None) is None
    assert writer._get_page_number_by_indirect(NullObject()) is None

    ind = writer.pages[0].indirect_reference
    assert writer._get_page_number_by_indirect(ind) == 0
    assert writer._get_page_number_by_indirect(ind.idnum) == 0
    assert writer._get_page_number_by_indirect(ind.idnum + 1) is None

Additionally, you state that this might simplify the writer. Do you have a direct use-case example for it?

[pubpub-zz]

it is due to some eof of line changes
These are introduced by the pre-commit checks, and most of the time after some new changes they are fixed automatically
It should be OK now