TST: simplify test_get_images

[tibor-reiss]

Fixes #2428

Imho, the test does too many things. Thus, instead of replacing with e.g. txt_file_path fixture, I removed things:

• write to file: The written file is never used. What was the reason to add it here in this test? -> Update: added back with tmp_path
• TypeError: does not seem to fit into this test -> Update: new test in test_page.py

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (109ef4a) to head (190b4fa).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2668   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          50       50           
  Lines        8356     8356           
  Branches     1673     1673           
=======================================
  Hits         7939     7939           
  Misses        259      259           
  Partials      158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pubpub-zz]

Fixes #2428

Imho, the test does too many things. Thus, instead of replacing with e.g. txt_file_path fixture, I removed things:

* write to file: The written file is never used. What was the reason to add it here in this test?

This may be expected to check that no exception are raised

* TypeError: does not seem to fit into this test

Have not been able to get through

I've rerun the checks to confirm coverage and your PR has reduced the test coverage. Can you please revisit it ?

[tibor-reiss]

@pubpub-zz Thanks for the quick feedback! I have added a new test to test_page.py so to cover the TypeError. And I added back the writing of the file - now with the tmp_path.

[pubpub-zz]

to prevent writing you may perhaps have a look at test_corrupted_jpeg_iss2266 in test_images.py

[tibor-reiss]

@pubpub-zz Would you like to check for similarity as in test_corrupted_jpeg_iss2266? For that I would need to add Image9.png to e.g. sample-files. Or would you prefer the Image.open(BytesIO...) construct? This is already part of the last assert though.

[stefan6419846]

Do we really need to write to the file system? Shouldn't writing to BytesIO() have the same effect without explicitly accessing the file system?

[tibor-reiss]

@pubpub-zz, @stefan6419846 I might be wrong, but since the second assert has already the manipulations with BytesIO, is there anything still missing, please? Let me know if I am misunderstanding something - for now, I have removed the writing to file.

[pubpub-zz]

out of tmp_path, coverage looks good

[stefan6419846]

Thanks for your patience.