Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Consistency of spaces after period #2717

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jun 17, 2024

Remove two spaces after a period so everywhere one space is used. Also, in _writer.py initialize PA.KIDS before PA.COUNT to match PDF specification table order.

Remove two spaces after a period so everywhere one space is used.
Also, in _writer.py initialize PA.KIDS before PA.COUNT to match PDF specification table order.
@stefan6419846
Copy link
Collaborator

Your changes seem to have some side-effects which have to be resolved before merging.

Remove two spaces after a period so everywhere one space is used.
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (988714f) to head (f6d92ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2717   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          51       51           
  Lines        8547     8547           
  Branches     1703     1703           
=======================================
  Hits         8132     8132           
  Misses        261      261           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846 stefan6419846 merged commit a195cb3 into py-pdf:main Jun 17, 2024
16 checks passed
@j-t-1 j-t-1 deleted the space branch June 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants