BUG: Make DictionaryObject.readFromStream check if any entry values refer to the null object #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object The only objects that can refer to the null object are the null object itself and indirect references to nonexisten objects. In principle, there could be an indirect reference to an existing object with value null. Catching this one would require resolving the indirect reference, which is too much effort.
…g them Entries with null values (either explicit or through references to nonexistent objects) are completely ignored and do not cause multiple definition errors if two entries are present for the same key and one has a null value. Fixes issue py-pdf#325 and proposes a behavior for issue py-pdf#236.
MartinThoma
added
the
is-bug
|
Hey! I know it's been 5 years since you opened the PR, but would to mind to fix the merge conflicts? |
MartinThoma
added
the
needs-change
MartinThoma
changed the title
MartinThoma
changed the title
MartinThoma
added
needs-rebase
|
I think this was solved through other means. The added test works with the current Please open a new PR if you think something from this PR should get into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite
DictionaryObject.readFromStreamto check if any entry values refer to thenullobject or to undefined objects. These entries are ignored and not committed into the object. A key with null value is treated as if it was absent from the dictionary (impacts #236) and does not cause a multiple definition error if it is set to a non-null value by another entry.Fixes #325