Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstring for Destination class #426

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

marramgrass
Copy link
Contributor

The constructor expects the page argument to be a reference to a page (IndirectObject), rather than the integer index of the page in the document. This change updates the docs for the class.

Also, my editor removed a couple of trailing spaces. Let me know and I'll remove those changes if you'd rather they weren't included here.

The constructor expects the page argument to be a reference
to a page, rather than the integer index of the page in the
document.
@MartinThoma MartinThoma merged commit eea0b72 into py-pdf:master Apr 6, 2022
@MartinThoma
Copy link
Member

Thank you for your contribution - I'm sorry it took so long!

@marramgrass marramgrass deleted the destination-documentation branch April 6, 2022 10:58
MartinThoma added a commit that referenced this pull request Apr 7, 2022
Features:

 - Add alpha channel support for png files in Script (#614)

Bug fixes (BUG):

 - Fix formatWarning for filename without slash (#612)
 - Add whitespace between words for extractText() (#569, #334)
 - "invalid escape sequence" SyntaxError (#522)
 - Avoid error when printing warning in pythonw (#486)
 - Stream operations can be List or Dict (#665)

Documentation (DOC):

 - Added Scripts/pdf-image-extractor.py
 - Documentation improvements (#550, #538, #324, #426, #394)

Tests and Test setup (TST):

 - Add Github Action which automatically run unit tests via pytest and
   static code analysis with Flake8 (#660)
 - Add several unit tests (#661, #663)
 - Add .coveragerc to create coverage reports

Developer Experience Improvements (DEV):

 - Pre commit: Developers can now `pre-commit install` to avoid tiny issues
               like trailing whitespaces

Miscallenious:

 - Add the LICENSE file to the distributed packages (#288)
 - Use setuptools instead of distutils (#599)
 - Improvements for the PyPI page (#644)
 - Python 3 changes (#504, #366)

You can see the full changelog at: 1.26.0...1.27.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants