Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: byte math errors for decoding bitmap pngs #536

Closed
wants to merge 5 commits into from
Closed

BUG: byte math errors for decoding bitmap pngs #536

wants to merge 5 commits into from

Conversation

chrisegner
Copy link

Fixes #535

@chrisegner
Copy link
Author

Oops - munged the commit a bit while cleaning up git. Fixed in 07f2dea.

@MartinThoma MartinThoma added the is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF label Apr 6, 2022
MartinThoma
MartinThoma reviewed Apr 16, 2022
View reviewed changes
PyPDF2/filters.py Outdated Show resolved Hide resolved
MartinThoma
MartinThoma reviewed Apr 16, 2022
View reviewed changes
PyPDF2/filters.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma changed the title fix: byte math errors for decoding bitmap pngs BUG: byte math errors for decoding bitmap pngs Apr 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #536 (8f11696) into main (4a3af96) will decrease coverage by 0.10%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   70.75%   70.65%   -0.11%     
==========================================
  Files          10       10              
  Lines        3430     3435       +5     
  Branches      798      800       +2     
==========================================
  Hits         2427     2427              
- Misses        759      764       +5     
  Partials      244      244
Impacted Files Coverage Δ
PyPDF2/filters.py 57.83% <6.25%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3af96...8f11696. Read the comment docs.

@MartinThoma
Copy link
Member

Sadly, this part is still untested. Would you mind adding a unit test? Or do you have an example PDF that triggers this code, then I can take care of it

@MartinThoma MartinThoma added the needs-test A test should be added before this PR is merged. label Apr 16, 2022
@MartinThoma MartinThoma added the needs-rebase This PR cannot be merged as the main branch is too different. You need to rebase or merge main. label Jun 26, 2022
MartinThoma added a commit that referenced this pull request Jul 6, 2022
@MartinThoma
BUG: Byte math errors for decoding bitmap PNGs
e3c2487 
Closes #535
Closes #536

Co-authored-by: Christopher Egner <chris@science.clinic>
@MartinThoma MartinThoma mentioned this pull request Jul 6, 2022
Merged
MartinThoma added a commit that referenced this pull request Jul 9, 2022
@MartinThoma
ENH: Add support for indexed color spaces / BitsPerComponent for deco…
f776f54 
…ding PNGs (#1067)

Closes #535
Closes #536

Co-authored-by: Christopher Egner <chris@science.clinic>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinThoma MartinThoma MartinThoma left review comments

Assignees
No one assigned
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF needs-rebase This PR cannot be merged as the main branch is too different. You need to rebase or merge main. needs-test A test should be added before this PR is merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitmap PNGs are not decoded
3 participants
@chrisegner @codecov-commenter @MartinThoma