Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Add error module #768

Merged
merged 7 commits into from Apr 16, 2022
Merged

STY: Add error module #768

merged 7 commits into from Apr 16, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #768 (2e5a916) into main (31fc4ce) will increase coverage by 0.03%.
The diff coverage is 38.80%.

@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   71.42%   71.46%   +0.03%     
==========================================
  Files          10       11       +1     
  Lines        3451     3455       +4     
  Branches      804      804              
==========================================
+ Hits         2465     2469       +4     
  Misses        734      734              
  Partials      252      252              
Impacted Files Coverage Δ
PyPDF2/generic.py 67.85% <10.52%> (ø)
PyPDF2/pdf.py 74.03% <20.00%> (+0.01%) ⬆️
PyPDF2/errors.py 100.00% <100.00%> (ø)
PyPDF2/filters.py 58.42% <100.00%> (+0.11%) ⬆️
PyPDF2/pagerange.py 98.07% <100.00%> (-0.04%) ⬇️
PyPDF2/utils.py 91.27% <100.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fc4ce...2e5a916. Read the comment docs.

@MartinThoma MartinThoma merged commit 1f0fbf3 into main Apr 16, 2022
@MartinThoma MartinThoma deleted the error-module branch April 16, 2022 15:18
MartinThoma added a commit that referenced this pull request Apr 18, 2022
Deprecations (DEP):
-  Remove support for Python 2.6 and older (#776)

New Features (ENH):
-  Extract document permissions (#320)

Bug Fixes (BUG):
-  Clip by trimBox when merging pages, which would otherwise be ignored (#240)
-  Add overwriteWarnings parameter PdfFileMerger (#243)
-  IndexError for getPage() of decryped file (#359)
-  Handle cases where decodeParms is an ArrayObject (#405)
-  Updated PDF fields don't show up when page is written (#412)
-  Set Linked Form Value (#414)
-  Fix zlib -5 error for corrupt files (#603)
-  Fix reading more than last1K for EOF (#642)
-  Acciental import

Robustness (ROB):
-  Allow extra whitespace before "obj" in readObjectHeader (#567)

Documentation (DOC):
-  Link to pdftoc in Sample_Code (#628)
-  Working with annotations (#764)
-  Structure history

Developer Experience (DEV):
-  Add issue templates (#765)
-  Add tool to generate changelog

Maintenance (MAINT):
-  Use grouped constants instead of string literals (#745)
-  Add error module (#768)
-  Use decorators for @staticmethod (#775)
-  Split long functions (#777)

Testing (TST):
-  Run tests in CI once with -OO Flags (#770)
-  Filling out forms (#771)
-  Add tests for Writer (#772)
-  Error cases (#773)
-  Check Error messages (#769)
-  Regression test for issue #88
-  Regression test for issue #327

Code Style (STY):
-  Make variable naming more consistent in tests

All changes: 1.27.5...1.27.6
@zeshuaro
Copy link

zeshuaro commented Apr 19, 2022

Hey @MartinThoma, for future breaking changes like this, can you highlight it in the changelog? It wasn't clear in the changelog that the most recent release contains breaking changes, and some users might need to update their code in order to use the latest version.

All good just saw #779

@MartinThoma
Copy link
Member Author

I wasn't aware that this is a breaking change. If I had thought about it, I would not have made the change at all 🙈

VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this pull request Apr 29, 2022
Deprecations (DEP):
-  Remove support for Python 2.6 and older (py-pdf#776)

New Features (ENH):
-  Extract document permissions (py-pdf#320)

Bug Fixes (BUG):
-  Clip by trimBox when merging pages, which would otherwise be ignored (py-pdf#240)
-  Add overwriteWarnings parameter PdfFileMerger (py-pdf#243)
-  IndexError for getPage() of decryped file (py-pdf#359)
-  Handle cases where decodeParms is an ArrayObject (py-pdf#405)
-  Updated PDF fields don't show up when page is written (py-pdf#412)
-  Set Linked Form Value (py-pdf#414)
-  Fix zlib -5 error for corrupt files (py-pdf#603)
-  Fix reading more than last1K for EOF (py-pdf#642)
-  Acciental import

Robustness (ROB):
-  Allow extra whitespace before "obj" in readObjectHeader (py-pdf#567)

Documentation (DOC):
-  Link to pdftoc in Sample_Code (py-pdf#628)
-  Working with annotations (py-pdf#764)
-  Structure history

Developer Experience (DEV):
-  Add issue templates (py-pdf#765)
-  Add tool to generate changelog

Maintenance (MAINT):
-  Use grouped constants instead of string literals (py-pdf#745)
-  Add error module (py-pdf#768)
-  Use decorators for @staticmethod (py-pdf#775)
-  Split long functions (py-pdf#777)

Testing (TST):
-  Run tests in CI once with -OO Flags (py-pdf#770)
-  Filling out forms (py-pdf#771)
-  Add tests for Writer (py-pdf#772)
-  Error cases (py-pdf#773)
-  Check Error messages (py-pdf#769)
-  Regression test for issue py-pdf#88
-  Regression test for issue py-pdf#327

Code Style (STY):
-  Make variable naming more consistent in tests

All changes: py-pdf/pypdf@1.27.5...1.27.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants