TST: Improve tests for convert_to_int

PyPDF2/_reader.py

@@ -94,7 +94,7 @@
 
 def convert_to_int(d: bytes, size: int) -> Union[int, Tuple[Any, ...]]:
     if size > 8:
-        raise PdfReadError("invalid size in convertToInt")
+        raise PdfReadError("invalid size in convert_to_int")
     d = b_("\x00\x00\x00\x00\x00\x00\x00\x00") + b_(d)
     d = d[-8:]
     return struct.unpack(">q", d)[0]

tests/test_basic_features.py

@@ -1,10 +1,6 @@
 import os
 
-import pytest
-
 from PyPDF2 import PdfReader, PdfWriter
-from PyPDF2._reader import convertToInt
-from PyPDF2.errors import PdfReadError
 
 TESTS_ROOT = os.path.abspath(os.path.dirname(__file__))
 PROJECT_ROOT = os.path.dirname(TESTS_ROOT)
@@ -59,9 +55,3 @@ def test_basic_features():
 
     # cleanup
     os.remove(tmp_path)
-
-
-def test_convertToInt():
-    with pytest.raises(PdfReadError) as exc:
-        convertToInt(b"256", 16)
-    assert exc.value.args[0] == "invalid size in convertToInt"

tests/test_reader.py

@@ -6,6 +6,7 @@
 import pytest
 
 from PyPDF2 import PdfReader
+from PyPDF2._reader import convert_to_int, convertToInt
 from PyPDF2.constants import ImageAttributes as IA
 from PyPDF2.constants import PageAttributes as PG
 from PyPDF2.constants import Ressources as RES
@@ -603,3 +604,18 @@ def test_VirtualList():
 
     # Test if getting as slice throws an error
     assert len(reader.pages[:]) == 1
+
+
+def test_convert_to_int():
+    assert convert_to_int(b'\x01', 8) == 1
+
+
+def test_convert_to_int_error():
+    with pytest.raises(PdfReadError) as exc:
+        convert_to_int(b"256", 16)
+    assert exc.value.args[0] == "invalid size in convert_to_int"
+
+
+def test_convertToInt_deprecated():
+    with pytest.warns(PendingDeprecationWarning, match="convertToInt will be removed with PyPDF2 2.0.0. Use convert_to_int instead."):
+        assert convertToInt(b'\x01', 8) == 1